CIP: Versioned Gas Scheduler Variables
Celestia Improvement Proposals (CIPs)2 posts452 views1 likesLast activity Oct 2024
NI
ninabarbakadzeOP
Jul 2024♥ 1This post is to discuss the CIP on Versioned Gas Scheduler Variables. More context here.
OB
oblique
Oct 2024Hey! I’m from Lumina team. We started implementing versioned consts from appconsts and we encounter some issues while incorporating them in our celestia-types crate.
These are the issues:
SubtreeRootThresholdis used whenBlob.Commitmentis computed, howeverAppVersionis only present inExtendedHeader. So if a user requests aBlob, they need first to requestExtendedHeader, thenBloband then pass theAppVersionin order to get theCommitment. In celestia-node you workaround this by having a fixed version of constants, which we believe it is going to be an issue later on.ExtendedDataSquarehas a theoreticalMAX_EXTENDED_SQUARE_WIDTH, which isSquareSizeUpperBound * 2. We use this value to validate EDS, but now this check can not be really done. We are unsure what to do about it. In order to keep this check then we need to apply restrictions on type-level and force user to give us theExtendedHeaderon validation.